Issue 13529004: Remove LOGGER macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13529004: Remove LOGGER macro (Closed)

Created:
7 years, 8 months ago by yurys

Modified:
7 years, 8 months ago

Reviewers:
loislo, Michael Starzinger, Yang, Jakob Kummerow

CC:
chromium-reviews

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove LOGGER macro Use already saved isolate pointer and avoid TLS lookup when retrieving Logger instance BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14168

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -31 lines)			Patch
M	src/isolate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/log.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/runtime.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-log.cc	View	1 2	14 chunks	+29 lines, -20 lines	0 comments	Download

Total messages: 4 (0 generated)

yurys

Committed patchset #4 manually as r14168 (presubmit successful).

7 years, 8 months ago (2013-04-08 15:17:08 UTC) #3

Michael Starzinger

7 years, 8 months ago (2013-04-09 09:14:19 UTC) #4

Message was sent while issue was closed.

Kudos, I like this CL! Deprecate all the TLS macors. :)