Issue 1352873002: Remove #include "base/basictypes.h" as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1352873002: Remove #include "base/basictypes.h" as appropriate (Closed)

Created:
5 years, 3 months ago by Mark Mentovai

Modified:
5 years, 3 months ago

Reviewers:
danakj, scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Remove #include "base/basictypes.h" as appropriate These files were only using basictypes.h for implicit_cast, which moved to util/misc/implicit_cast.h in 0b022d72a2a4. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4ff6c2d71f519c74214c679fa78dda4c2581dcc9

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -4 lines)			Patch
M	util/mach/mach_message.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	util/mach/mach_message_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	util/posix/close_multiple.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	util/posix/process_info_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Mark Mentovai

Committed patchset #1 (id:1) manually as 4ff6c2d71f519c74214c679fa78dda4c2581dcc9 (presubmit successful).

5 years, 3 months ago (2015-09-17 16:32:43 UTC) #5

Message was sent while issue was closed.

LGTM