content/browser/frame_host/frame_tree.cc - Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing some of the current CR comments (before moving on to eliminate the pending WebUI). Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/frame_tree.cc

diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc

index ac61afa5240b7d354ad2e4f6b558483f6fb19930..04c949c4d8e7a980b9bcbe8c174aadc6035f3fdb 100644

--- a/content/browser/frame_host/frame_tree.cc

+++ b/content/browser/frame_host/frame_tree.cc

@@ -242,8 +242,7 @@ void FrameTree::CreateProxiesForSiteInstance(

root()->render_manager()->CreateRenderFrameProxy(site_instance);

} else {

root()->render_manager()->CreateRenderFrame(

- site_instance, nullptr, CREATE_RF_SWAPPED_OUT | CREATE_RF_HIDDEN,

- nullptr);

+ site_instance, CREATE_RF_SWAPPED_OUT | CREATE_RF_HIDDEN, nullptr);

}

} else {

root()->render_manager()->EnsureRenderViewInitialized(render_view_host,

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_delegate.h » ('j') | content/browser/frame_host/render_frame_host_manager.cc » ('J')