content/browser/frame_host/render_frame_host_delegate.h - Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and fixed conflicts of the revert of http://crbug.com/1403343002 :/ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/frame_tree.cc ('k') | content/browser/frame_host/render_frame_host_delegate.cc » ('j') | content/browser/frame_host/render_frame_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_delegate.h

diff --git a/content/browser/frame_host/render_frame_host_delegate.h b/content/browser/frame_host/render_frame_host_delegate.h

index 0f8e555d30cbc4f01c1ee17cd969278044a0de4e..d6f7a161241f7c15e2ff370398c7f8adcb10a55d 100644

--- a/content/browser/frame_host/render_frame_host_delegate.h

+++ b/content/browser/frame_host/render_frame_host_delegate.h

@@ -9,6 +9,7 @@

#include "base/basictypes.h"

#include "base/i18n/rtl.h"

+#include "content/browser/webui/web_ui_impl.h"

Dan Beam 2015/10/22 20:56:31 why not forward declare instead?

carlosk 2015/10/27 14:35:44 I tried that but the compiler screams at me becaus

#include "content/common/content_export.h"

#include "content/common/frame_message_enums.h"

#include "content/public/browser/site_instance.h"

@@ -163,6 +164,10 @@ class CONTENT_EXPORT RenderFrameHostDelegate {

// https://crbug.com/330264.

virtual void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) {}

+ // Creates a WebUI object for a frame navigating to the given URL. If no WebUI

+ // applies, returns null.

+ virtual scoped_ptr<WebUIImpl> CreateWebUIForRenderFrameHost(const GURL& url);

#if defined(OS_WIN)

// Returns the frame's parent's NativeViewAccessible.

virtual gfx::NativeViewAccessible GetParentNativeViewAccessible();