content/browser/webui/web_ui_impl.h - Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/web_ui_impl.h

Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More test fixes and improvements but the code is stil a WIP! Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/browser/webui/web_ui_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/webui/web_ui_impl.h

diff --git a/content/browser/webui/web_ui_impl.h b/content/browser/webui/web_ui_impl.h

index d38da2a80062b8d6b280274dc1578bccef1fee1d..4a433190339bec080de28ae3195728b686baabab 100644

--- a/content/browser/webui/web_ui_impl.h

+++ b/content/browser/webui/web_ui_impl.h

@@ -25,11 +25,6 @@ class CONTENT_EXPORT WebUIImpl : public WebUI,

WebUIImpl(WebContents* contents, const std::string& frame_name);

~WebUIImpl() override;

- // Called by WebContentsImpl when the RenderView is first created. This is

- // *not* called for every page load because in some cases

- // RenderFrameHostManager will reuse RenderView instances.

- void RenderViewCreated(RenderViewHost* render_view_host);

// WebUI implementation:

WebContents* GetWebContents() const override;

WebUIController* GetController() const override;

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/browser/webui/web_ui_impl.cc » ('j') | no next file with comments »