Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.

content/browser/frame_host/render_frame_host_manager_unittest.cc

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index a6d04cde898ee2a6118990c8c7427b528d7cb1ec..d2898c2f46952cf01fbe1d2e67a625203f3e41bf 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -72,7 +72,9 @@ class RenderFrameHostManagerTestWebUIControllerFactory
 
   WebUI::TypeID GetWebUIType(BrowserContext* browser_context,
                              const GURL& url) const override {
-    return WebUI::kNoWebUI;
+    if (!(should_create_webui_ && HasWebUIScheme(url)))

[nasko, 2015/10/14 23:54:15]

Why not invert the code such that you don't have ! and return the casted this,
otherwise return kNoWebUI.

Also, a comment on why this is needed will be good to have. As I read through
this, I'm not quite sure why this is done.

[carlosk, 2015/10/15 16:34:08]

This is done so that this code actually conforms to what this method
implementation is expected to do. This was a bad mock in the first place but it
worked because the previous logic didn't rely on this type value having the
correct value returned.

You can see I simply copy/pasted the same logic used above to get the
WebUIController instance. I'll invert both implementations and add a comment.

+      return WebUI::kNoWebUI;
+    return const_cast<RenderFrameHostManagerTestWebUIControllerFactory*>(this);
   }
 
   bool UseWebUIForURL(BrowserContext* browser_context,