content/test/test_render_frame_host.cc - Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Doesn't try to create a WebUI if URL is invalid (fixes unit_tests). Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/test/test_render_frame_host.h ('k') | content/test/test_render_frame_host_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index 0c89a13fb8538d1a9b14a0013e0bf57a8cea97b3..03073e9f3464a83b9786a6c7f496940084503dfe 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -48,7 +48,9 @@ TestRenderFrameHost::TestRenderFrameHost(SiteInstance* site_instance,

FrameTreeNode* frame_tree_node,

int32 routing_id,

int32 widget_routing_id,

- int flags)

+ int flags,

+ const GURL& dest_url,

+ int entry_bindings)

: RenderFrameHostImpl(site_instance,

render_view_host,

delegate,

@@ -57,7 +59,9 @@ TestRenderFrameHost::TestRenderFrameHost(SiteInstance* site_instance,

frame_tree_node,

routing_id,

widget_routing_id,

- flags),

+ flags,

+ dest_url,

+ entry_bindings),

child_creation_observer_(delegate ? delegate->GetAsWebContents() : NULL),

contents_mime_type_("text/html"),

simulate_history_list_was_cleared_(false) {}

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/test/test_render_frame_host.h ('k') | content/test/test_render_frame_host_factory.h » ('j') | no next file with comments »