Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed InitializeWebUI Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/i18n/rtl.h" 11 #include "base/i18n/rtl.h"
12 #include "content/browser/webui/web_ui_impl.h"
12 #include "content/common/content_export.h" 13 #include "content/common/content_export.h"
13 #include "content/common/frame_message_enums.h" 14 #include "content/common/frame_message_enums.h"
14 #include "content/public/browser/site_instance.h" 15 #include "content/public/browser/site_instance.h"
15 #include "content/public/common/javascript_message_type.h" 16 #include "content/public/common/javascript_message_type.h"
16 #include "content/public/common/media_stream_request.h" 17 #include "content/public/common/media_stream_request.h"
17 #include "net/http/http_response_headers.h" 18 #include "net/http/http_response_headers.h"
18 19
19 #if defined(OS_WIN) 20 #if defined(OS_WIN)
20 #include "ui/gfx/native_widget_types.h" 21 #include "ui/gfx/native_widget_types.h"
21 #endif 22 #endif
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // 157 //
157 // TODO(alexmos): This method currently supports cross-process postMessage, 158 // TODO(alexmos): This method currently supports cross-process postMessage,
158 // where we may need to create any missing proxies for the message's source 159 // where we may need to create any missing proxies for the message's source
159 // frame and its opener chain. It currently exists in WebContents due to a 160 // frame and its opener chain. It currently exists in WebContents due to a
160 // special case for <webview> guests, but this logic should eventually be 161 // special case for <webview> guests, but this logic should eventually be
161 // moved down into RenderFrameProxyHost::RouteMessageEvent when <webview> 162 // moved down into RenderFrameProxyHost::RouteMessageEvent when <webview>
162 // refactoring for --site-per-process mode is further along. See 163 // refactoring for --site-per-process mode is further along. See
163 // https://crbug.com/330264. 164 // https://crbug.com/330264.
164 virtual void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) {} 165 virtual void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) {}
165 166
167 // Creates a WebUI object for a main frame navigating to the given URL. If no
clamy 2015/10/02 14:20:01 Is this only called by main frames? Do subframes c
carlosk 2015/10/05 16:59:57 Gah! I missed updating this comment! Clarifying:
168 // WebUI applies, returns nullptr. Ownership of the returned pointer will be
169 // passed to the caller.
170 virtual scoped_ptr<WebUIImpl> CreateWebUIForRenderFrameHost(const GURL& url);
171
166 #if defined(OS_WIN) 172 #if defined(OS_WIN)
167 // Returns the frame's parent's NativeViewAccessible. 173 // Returns the frame's parent's NativeViewAccessible.
168 virtual gfx::NativeViewAccessible GetParentNativeViewAccessible(); 174 virtual gfx::NativeViewAccessible GetParentNativeViewAccessible();
169 #endif 175 #endif
170 176
171 protected: 177 protected:
172 virtual ~RenderFrameHostDelegate() {} 178 virtual ~RenderFrameHostDelegate() {}
173 }; 179 };
174 180
175 } // namespace content 181 } // namespace content
176 182
177 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 183 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698