Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.

content/browser/frame_host/render_frame_host_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
 
 #include <map>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
 #include "content/browser/site_instance_impl.h"
+#include "content/browser/webui/web_ui_impl.h"
 #include "content/common/accessibility_mode_enums.h"
 #include "content/common/ax_content_node_data.h"
 #include "content/common/content_export.h"
 #include "content/common/frame_message_enums.h"
 #include "content/common/frame_replication_state.h"
 #include "content/common/image_downloader/image_downloader.mojom.h"
 #include "content/common/mojo/service_registry_impl.h"
 #include "content/common/navigation_params.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/common/javascript_message_type.h"
@@ skipping 176 matching lines @@
   int routing_id() const { return routing_id_; }
   void OnCreateChildFrame(int new_routing_id,
                           blink::WebTreeScopeType scope,
                           const std::string& frame_name,
                           blink::WebSandboxFlags sandbox_flags);
 
   RenderViewHostImpl* render_view_host() { return render_view_host_; }
   RenderFrameHostDelegate* delegate() { return delegate_; }
   FrameTreeNode* frame_tree_node() { return frame_tree_node_; }
 
+  // Returns the associated Web UI or nullptr if none applies.
+  WebUIImpl* web_ui() const { return web_ui_.get(); }
+
+  // Returns the pending associated Web UI, or nullptr of none applies.
+  WebUIImpl* pending_web_ui() const {
+    return should_reuse_web_ui_ ? web_ui_.get() : pending_web_ui_.get();
+  }
+
   // Returns this RenderFrameHost's loading state. This method is only used by
   // FrameTreeNode. The proper way to check whether a frame is loading is to
   // call FrameTreeNode::IsLoading.
   bool is_loading() const { return is_loading_; }
 
   // This returns the RenderFrameHost's owned RenderWidgetHost if it has one,
   // or else it returns nullptr.
   // If the RenderFrameHost is the page's main frame, this returns instead a
   // pointer to the RenderViewHost (which inherits RenderWidgetHost).
   RenderWidgetHostImpl* GetRenderWidgetHost();
@@ skipping 232 matching lines @@
 
   // Tears down the browser-side state relating to the Mojo connection between
   // this instance and its associated render frame.
   void InvalidateMojoConnection();
 
   // Returns whether the frame is focused. A frame is considered focused when it
   // is the parent chain of the focused frame within the frame tree. In
   // addition, its associated RenderWidgetHost has to be focused.
   bool IsFocused();
 
+  // Initializes the first WebUI for a recently created RenderFrameHost, if one
+  // is required by |dest_url|. No WebUI must have been set before and it must
+  // be called only once. If this is a history navigation to an existing
+  // NavigationEntry, providing its |past_bindings| will allow verifying that
+  // bindings are not being set differently this time around.

[clamy, 2015/10/01 13:15:13]

If it's not a history entry, what should the value of past_bindings be?

[carlosk, 2015/10/01 16:00:22]

This method was removed.

+  void InitializeWebUI(const GURL& dest_url, int past_bindings);
+
+  // Creates or replaces the pending WebUI for this RFH. Same logic from
+  // InitializeWebUI applies for the provided parameters. If the new WebUI to be
+  // created matches the current active or existing existing ones, they will be
+  // reused.

[clamy, 2015/10/01 13:15:13]

Should you also provide past bindings when navigating to a history entry?

[carlosk, 2015/10/01 16:00:22]

I improved all WebUI methods comments to make them clearer.

+  void UpdatePendingWebUI(const GURL& dest_url, int past_bindings);
+
+  // Replaces the active WebUI with the pending one.
+  void CommitPendingWebUI();
+
+  // Destroy the pending WebUI and cleans up any related data.
+  void DiscardPendingWebUI();
+
   // Returns the Mojo ImageDownloader service.
   const image_downloader::ImageDownloaderPtr& GetMojoImageDownloader();
 
  protected:
   friend class RenderFrameHostFactory;
 
   // |flags| is a combination of CreateRenderFrameFlags.
   // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
   // should be the abstraction needed here, but we need RenderViewHost to pass
   // into WebContentsObserver::FrameDetached for now.
@@ skipping 126 matching lines @@
   // Convert the content-layer-specific AXContentNodeData to a general-purpose
   // AXNodeData structure.
   void AXContentNodeDataToAXNodeData(const AXContentNodeData& src,
                                      ui::AXNodeData* dst);
 
   // Returns the RenderWidgetHostView used for accessibility. For subframes,
   // this function will return the platform view on the main frame; for main
   // frames, it will return the current frame's view.
   RenderWidgetHostViewBase* GetViewForAccessibility();
 
+  // Creates a WebUI object for the given URL if one applies and sets
+  // |web_ui_type| to its type, also ensuring that its bindings match
+  // |past_bindings| (if provided and different than
+  // NavigationEntryImpl::kInvalidBindings). If no WebUI applies, returns
+  // nullptr and resets web_ui_type to WebUI::kNoWebUI. .
+  scoped_ptr<WebUIImpl> CreateWebUI(const GURL& dest_url,
+                                    int past_bindings,
+                                    WebUI::TypeID* web_ui_type);
+
   // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
   // refcount that calls Shutdown when it reaches zero.  This allows each
   // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
   // we have a RenderViewHost for each RenderFrameHost.
   // TODO(creis): RenderViewHost will eventually go away and be replaced with
   // some form of page context.
   RenderViewHostImpl* render_view_host_;
 
   RenderFrameHostDelegate* delegate_;
 
@@ skipping 148 matching lines @@
   // Holder of Mojo connection with ImageDownloader service in RenderFrame.
   image_downloader::ImageDownloaderPtr mojo_image_downloader_;
 
   // Tracks a navigation happening in this frame. Note that while there can be
   // two navigations in the same FrameTreeNode, there can only be one
   // navigation per RenderFrameHost.
   // PlzNavigate: before the navigation is ready to be committed, the
   // NavigationHandle for it is owned by the NavigationRequest.
   scoped_ptr<NavigationHandleImpl> navigation_handle_;
 
+  // The associated WebUIImpl and its type. They will be set if the current page
+  // is a Web UI page. Otherwise they will be nullptr and WebUI::kNoWebUI,
+  // respectively.
+  scoped_ptr<WebUIImpl> web_ui_;

[clamy, 2015/10/01 13:15:13]

Would it be possible to modify the WebUI so that it returns its type. It's a bit
annoying to have to store those 2 parameters together.

[carlosk, 2015/10/01 16:00:22]

I agree and it is possible. But nasko@ mentioning once that having GetType
methods is discouraged and it would be needed in that case. So nasko@, WDYT?

+  WebUI::TypeID web_ui_type_;
+
+  // Stores a pending WebUIImpl and its type. These will only be set during a
+  // same-site navigation to a WebUI page (reusing this RenderFrameHost).
+  scoped_ptr<WebUIImpl> pending_web_ui_;
+  WebUI::TypeID pending_web_ui_type_;
+
+  // If true at commit time the current WebUI will simply be reused (no pending
+  // one will exist to be committed).

[clamy, 2015/10/01 13:15:13]

Then, is it equivalent to !pending_web_ui_?

[carlosk, 2015/10/01 16:00:22]

No because if this is false and the pending WebUI is nullptr, that will cause
the current WebUI to be destroyed and none to be put in its place.

+  bool should_reuse_web_ui_;
+
   // NOTE: This must be the last member.
   base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_