Issue 1352793003: Cleanup: Pass std::string as const reference from chrome_elf/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1352793003: Cleanup: Pass std::string as const reference from chrome_elf/ (Closed)

Created:
5 years, 3 months ago by ki.stfu

Modified:
5 years, 3 months ago

Reviewers:
robertshield, Cait (Slow)

CC:
chromium-reviews, kalyank, sadrul, caitkp+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: Pass std::string as const reference from chrome_elf/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=caitkp@chromium.org,robertshield@chromium.org Committed: https://crrev.com/b3289e3585348883a3cac9a5cafc986d521bbb39 Cr-Commit-Position: refs/heads/master@{#349887}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome_elf/dll_hash/dll_hash.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome_elf/dll_hash/dll_hash.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352793003/1

5 years, 3 months ago (2015-09-20 22:07:07 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-20 23:20:43 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b3289e3585348883a3cac9a5cafc986d521bbb39
Cr-Commit-Position: refs/heads/master@{#349887}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages