Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1352763003: cc: Address comments for https://codereview.chromium.org/1287043002/ (Closed)

Created:
5 years, 3 months ago by no sievers
Modified:
5 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sohan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Address comments for API to release OutputSurface This lets us land https://codereview.chromium.org/1287043002/ while the author is away, and follow up here. Some fixes for trace events, dchecks, and code sharing. BUG=374906 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e83e41db9ac1efad11c7899ec3019064145e14d9 Cr-Commit-Position: refs/heads/master@{#349808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
no sievers
ptal
5 years, 3 months ago (2015-09-18 22:15:02 UTC) #2
danakj
LGTM
5 years, 3 months ago (2015-09-18 22:18:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352763003/1
5 years, 3 months ago (2015-09-18 22:52:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 23:33:33 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e83e41db9ac1efad11c7899ec3019064145e14d9 Cr-Commit-Position: refs/heads/master@{#349808}
5 years, 3 months ago (2015-09-18 23:34:03 UTC) #7
sohanjg
5 years, 3 months ago (2015-09-23 13:33:05 UTC) #8
Message was sent while issue was closed.
On 2015/09/18 23:34:03, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e83e41db9ac1efad11c7899ec3019064145e14d9
> Cr-Commit-Position: refs/heads/master@{#349808}

thanks for looking into the comments sievers.

Powered by Google App Engine
This is Rietveld 408576698