Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1352743002: MacViews: Synchronize resize operations with the GPU process (Closed)

Created:
5 years, 3 months ago by tapted
Modified:
5 years, 2 months ago
Reviewers:
ccameron
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20150907-MacViews-ResizeHelperContent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Synchronize liveResize operations with the GPU process Currently composited UI frames during a live-resize arrive out of sync, and get queued up, resulting in wasted work and odd behavior where the window contents lag behind the window size. To fix, use ui::WindowResizeHelperMac to watch messages coming in from the GPU process and block the UI thread until it's ready to display a composited frame that matches the window. For now, just fix resize, which hooks in via -[NSWindowDelegate windowDidResize:]. In future, we may want to block for other cases (E.g. showing a window-modal sheet should wait before starting the animation.) BUG=531831 Committed: https://crrev.com/8ffc5c5a955fa1395f6476927b5fdbc59ee8b767 Cr-Commit-Position: refs/heads/master@{#351012}

Patch Set 1 #

Patch Set 2 : Much simpler... #

Patch Set 3 : Fewer changes - just fix resize for now #

Patch Set 4 : More specific #

Patch Set 5 : Visibility check #

Patch Set 6 : inLiveResize #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M ui/views/cocoa/bridged_native_widget.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 2 3 4 5 5 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tapted
Hi Chris, please take a look (assuming that other CL goes through..). I've trimmed this ...
5 years, 3 months ago (2015-09-18 07:56:58 UTC) #3
tapted
Hi Chris, now that r350449 has landed, could you take a look when you get ...
5 years, 3 months ago (2015-09-24 08:52:16 UTC) #4
ccameron
This lgtm
5 years, 2 months ago (2015-09-25 19:59:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352743002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352743002/140001
5 years, 2 months ago (2015-09-27 23:51:22 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 2 months ago (2015-09-28 00:15:00 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 00:15:51 UTC) #9
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/8ffc5c5a955fa1395f6476927b5fdbc59ee8b767
Cr-Commit-Position: refs/heads/master@{#351012}

Powered by Google App Engine
This is Rietveld 408576698