Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 1352733002: Remove some more embedded pointers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm.cc
diff --git a/runtime/vm/intrinsifier_arm.cc b/runtime/vm/intrinsifier_arm.cc
index 7d3421d5489b1751dbdf2a5c8eb015a43325f2e8..28a16a302d467f53ba19990424b7ae11677a28eb 100644
--- a/runtime/vm/intrinsifier_arm.cc
+++ b/runtime/vm/intrinsifier_arm.cc
@@ -1575,14 +1575,10 @@ void Intrinsifier::ObjectEquals(Assembler* assembler) {
// Return type quickly for simple types (not parameterized and not signature).
void Intrinsifier::ObjectRuntimeType(Assembler* assembler) {
Label fall_through;
- static const intptr_t kSmiCidSource = kSmiCid << RawObject::kClassIdTagPos;
__ ldr(R0, Address(SP, 0 * kWordSize));
-
- __ LoadImmediate(TMP, reinterpret_cast<int32_t>(&kSmiCidSource) + 1);
- __ tst(R0, Operand(kSmiTagMask));
- __ mov(TMP, Operand(R0), NE);
- __ LoadClassId(R1, TMP);
+ __ LoadClassIdMayBeSmi(R1, R0);
__ LoadClassById(R2, R1);
+
// R2: class of instance (R0).
__ ldr(R3, FieldAddress(R2, Class::signature_function_offset()));
__ CompareObject(R3, Object::null_object());
@@ -1760,7 +1756,8 @@ static void TryAllocateOnebyteString(Assembler* assembler,
Label* failure) {
const Register length_reg = R2;
Label fail;
- __ MaybeTraceAllocation(kOneByteStringCid, R0, failure);
+ __ MaybeTraceAllocation(kOneByteStringCid, R0, failure,
+ /* inline_isolate = */ false);
__ mov(R6, Operand(length_reg)); // Save the length register.
// TODO(koda): Protect against negative length and overflow here.
__ SmiUntag(length_reg);
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698