tools/dom/src/CssRectangle.dart - Issue 135273009: Make Rectangle and MutableRectangle constructors handle negative lengths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/CssRectangle.dart

Issue 135273009: Make Rectangle and MutableRectangle constructors handle negative lengths. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Update tests. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/src/CssRectangle.dart

diff --git a/tools/dom/src/CssRectangle.dart b/tools/dom/src/CssRectangle.dart

index fe1c56235b399a043891d963775ca4291b72edd4..e82ddd9d9f5872c326e96c822ebbf9dff715f3a1 100644

--- a/tools/dom/src/CssRectangle.dart

+++ b/tools/dom/src/CssRectangle.dart

@@ -157,7 +157,7 @@ class _MarginCssRect extends CssRect {

* animation frame is discouraged. See also:

* [Browser Reflow](https://developers.google.com/speed/articles/reflow)

-abstract class CssRect extends MutableRectangle<num> implements Rectangle<num> {

+abstract class CssRect extends MutableRectangle<num> {

Element _element;

CssRect(this._element) : super(0, 0, 0, 0);

« no previous file with comments | « tests/lib/math/rectangle_test.dart ('k') | no next file » | no next file with comments »