Get logging to chrome_debug.log working again on Windows Vista+.

content/common/sandbox_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/sandbox_win.h"
 
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/debug/profiler.h"
 #include "base/files/file_util.h"
 #include "base/hash.h"
+#include "base/logging.h"
 #include "base/memory/shared_memory.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event.h"
 #include "base/win/iat_patch_function.h"
 #include "base/win/scoped_handle.h"
@@ skipping 710 matching lines @@
                              exposed_files.value().c_str());
     if (result != sandbox::SBOX_ALL_OK)
       return base::Process();
   }
 
   if (!AddGenericPolicy(policy)) {
     NOTREACHED();
     return base::Process();
   }
 
+  // Allow the renderer and gpu processes to access the log file.
+  if (type_str == switches::kRendererProcess ||
+      type_str == switches::kGpuProcess) {
+    if (logging::IsLoggingToFileEnabled()) {
+      policy->AddRule(sandbox::TargetPolicy::SUBSYS_FILES,
+                      sandbox::TargetPolicy::FILES_ALLOW_ANY,
+                      logging::GetLogFileFullPath().c_str());

[scottmg, 2015/09/16 23:30:47]

is it ok if this path is relative?

[ananta, 2015/09/16 23:49:38]

It will not be relative in this patch. It is updated to the current directory
path + debug.log

+    }
+  }
+
 #if !defined(OFFICIAL_BUILD)
   // If stdout/stderr point to a Windows console, these calls will
   // have no effect.
   policy->SetStdoutHandle(GetStdHandle(STD_OUTPUT_HANDLE));
   policy->SetStderrHandle(GetStdHandle(STD_ERROR_HANDLE));
 #endif
 
   if (delegate) {
     bool success = true;
     delegate->PreSpawnTarget(policy, &success);
@@ skipping 73 matching lines @@
   }
 
   return false;
 }
 
 bool BrokerAddTargetPeer(HANDLE peer_process) {
   return g_broker_services->AddTargetPeer(peer_process) == sandbox::SBOX_ALL_OK;
 }
 
 }  // namespace content