Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 13527007: Ensure UseRegisterAtStart not used with fixed temp/return register (Closed)

Created:
7 years, 8 months ago by danno
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Ensure UseRegisterAtStart not used with fixed temp/return register R=vegorov@chromium.org BUG=chromium:201590 Committed: http://code.google.com/p/v8/source/detail?r=14124

Patch Set 1 #

Patch Set 2 : Add missing case #

Patch Set 3 : Fix another missed case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -23 lines) Patch
M src/arm/lithium-arm.cc View 1 2 3 chunks +33 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +34 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-201590.js View 1 chunk +30 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
please take a look
7 years, 8 months ago (2013-04-03 13:59:12 UTC) #1
Vyacheslav Egorov (Google)
lgtm
7 years, 8 months ago (2013-04-03 14:09:58 UTC) #2
Vyacheslav Egorov (Chromium)
lgtm
7 years, 8 months ago (2013-04-03 14:10:16 UTC) #3
Vyacheslav Egorov (Chromium)
still lgtm
7 years, 8 months ago (2013-04-03 14:22:28 UTC) #4
danno
7 years, 8 months ago (2013-04-03 14:45:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r14124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698