Issue 1352683002: Make the suppressed copy/assignment operators in MOJO_MOVE_ONLY_TYPE take const refs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1352683002: Make the suppressed copy/assignment operators in MOJO_MOVE_ONLY_TYPE take const refs. (Closed)

Created:
5 years, 3 months ago by viettrungluu

Modified:
5 years, 3 months ago

Reviewers:
jamesr, kulakowski

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make the suppressed copy/assignment operators in MOJO_MOVE_ONLY_TYPE take const refs. If it's good for Chromium (https://codereview.chromium.org/1061073004), it's good for us, right? R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2980a5fe34396f731801c7ea752c41c1d1865e37

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/public/cpp/system/macros.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

5 years, 3 months ago (2015-09-16 23:03:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2980a5fe34396f731801c7ea752c41c1d1865e37 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages