Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1352663002: Extract some stuff into PackageManager (Closed)

Created:
5 years, 3 months ago by Ben Goodger (Google)
Modified:
5 years, 3 months ago
Reviewers:
yzshen1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract some stuff into PackageManager: - content handler determination from ApplicationManager::HandleFetchCallback - content handler registration - renames BaseApplicationFetcher to PackageManagerImpl. R=yzshen@chromium.org BUG= Committed: https://crrev.com/59e4ed2dd7f05972f687d628df0ba9c9cc35eb97 Cr-Commit-Position: refs/heads/master@{#349357}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 5

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -376 lines) Patch
M content/browser/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M mandoline/app/desktop/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mojo/fetcher/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/fetcher/about_fetcher_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
D mojo/fetcher/base_application_fetcher.h View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/fetcher/base_application_fetcher.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 2 3 4 chunks +5 lines, -2 lines 0 comments Download
A + mojo/package_manager/BUILD.gn View 1 2 3 4 5 1 chunk +6 lines, -6 lines 0 comments Download
A + mojo/package_manager/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/package_manager/package_manager_impl.h View 1 2 3 4 5 1 chunk +76 lines, -0 lines 0 comments Download
A mojo/package_manager/package_manager_impl.cc View 1 2 3 4 5 1 chunk +172 lines, -0 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M mojo/runner/context.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M mojo/runner/context.cc View 1 5 chunks +9 lines, -7 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 3 chunks +3 lines, -1 line 0 comments Download
D mojo/shell/application_fetcher.h View 1 chunk +0 lines, -43 lines 0 comments Download
M mojo/shell/application_manager.h View 1 2 5 chunks +3 lines, -20 lines 0 comments Download
M mojo/shell/application_manager.cc View 6 chunks +33 lines, -94 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 10 chunks +31 lines, -32 lines 0 comments Download
M mojo/shell/capability_filter_unittest.cc View 1 7 chunks +13 lines, -17 lines 0 comments Download
A mojo/shell/package_manager.h View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A mojo/shell/test_package_manager.h View 1 2 3 4 5 1 chunk +52 lines, -0 lines 0 comments Download
A mojo/shell/test_package_manager.cc View 1 2 3 4 5 6 7 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Ben Goodger (Google)
5 years, 3 months ago (2015-09-16 22:21:50 UTC) #2
yzshen1
LGTM Only some nits: https://codereview.chromium.org/1352663002/diff/60001/mojo/package_manager/BUILD.gn File mojo/package_manager/BUILD.gn (right): https://codereview.chromium.org/1352663002/diff/60001/mojo/package_manager/BUILD.gn#newcode5 mojo/package_manager/BUILD.gn:5: import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni") nit: Likely this line ...
5 years, 3 months ago (2015-09-16 23:47:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352663002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352663002/100001
5 years, 3 months ago (2015-09-17 00:01:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/133553)
5 years, 3 months ago (2015-09-17 00:55:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352663002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352663002/120001
5 years, 3 months ago (2015-09-17 03:07:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/133630)
5 years, 3 months ago (2015-09-17 03:35:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352663002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352663002/140001
5 years, 3 months ago (2015-09-17 04:21:48 UTC) #16
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 3 months ago (2015-09-17 05:06:55 UTC) #17
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/59e4ed2dd7f05972f687d628df0ba9c9cc35eb97 Cr-Commit-Position: refs/heads/master@{#349357}
5 years, 3 months ago (2015-09-17 05:07:42 UTC) #18
yosin_UTC9
5 years, 3 months ago (2015-09-17 06:18:01 UTC) #19
Message was sent while issue was closed. 
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1350023002/ by yosin@chromium.org.

The reason for reverting is: Compilation error in test_package_manager.h

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/mojo/shell/mojo_shell_unittests/test_package_manager.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS
-DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1
-DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1
-DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=245965-1 -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0
-DGTEST_HAS_RTTI=0 -DUNIT_TEST -I../.. -Igen -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/mojo/src
-Igen/third_party/mojo/src -I../../testing/gtest/include -fno-strict-aliasing
--param=ssp-buffer-size=4 -fstack-protector -m64 -march=x86-64 -funwind-tables
-fPIC -pipe -pthread -B../../third_party/binutils/Linux_x64/Release/bin
-fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-Wno-inconsistent-missing-override -Wno-shift-negative-value -O2 -fno-ident
-fdata-sections -ffunction-sections -g1 -fvisibility=hidden -Xclang -load
-Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion
-Wthread-safety -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11
-fno-rtti -fno-exceptions -c ../../mojo/shell/test_package_manager.cc -o
obj/mojo/shell/mojo_shell_unittests/test_package_manager.o
In file included from ../../mojo/shell/test_package_manager.cc:5:
../../mojo/shell/test_package_manager.h:23:32: error: [chromium-style]
Overriding method must be marked with 'override' or 'final'.
  virtual ~TestPackageManager();
                               ^
                                override
1 error generated.
.

Powered by Google App Engine
This is Rietveld 408576698