Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1352623006: command_buffer: Remove redundant extension checks from two decoder functions (Closed)

Created:
5 years, 3 months ago by Kimmo Kinnunen
Modified:
5 years, 2 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@context-type-rebase
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command_buffer: Remove redundant extension checks from two decoder functions Remove redundant checks of extension feature flag from two gl path rendering related matrix functions. The check is for function X is nowadays done at HandleX() functions. The HandleX functions are generated by the code generator for these matrix functions. BUG=344330 NOTRY=true Committed: https://crrev.com/dd449f5196bc727a287c13fb09b4b9cbcbd9c7e4 Cr-Commit-Position: refs/heads/master@{#351627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Kimmo Kinnunen
5 years, 2 months ago (2015-09-25 08:05:28 UTC) #2
Zhenyao Mo
On 2015/09/25 08:05:28, Kimmo Kinnunen wrote: LGTM
5 years, 2 months ago (2015-09-30 03:20:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352623006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352623006/1
5 years, 2 months ago (2015-09-30 05:53:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/120068)
5 years, 2 months ago (2015-09-30 07:06:30 UTC) #7
Zhenyao Mo
Mac failure is unrelated. Landing with NOTRY=true.
5 years, 2 months ago (2015-09-30 20:03:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352623006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352623006/1
5 years, 2 months ago (2015-09-30 20:05:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 20:14:00 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 20:14:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd449f5196bc727a287c13fb09b4b9cbcbd9c7e4
Cr-Commit-Position: refs/heads/master@{#351627}

Powered by Google App Engine
This is Rietveld 408576698