Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3259)

Unified Diff: ash/system/bluetooth/tray_bluetooth.cc

Issue 1352613004: Cleanup: Pass std::string as const reference from ash/ + minor coding style changes in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove const qualifier for int in function arguments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/test/test_session_state_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/bluetooth/tray_bluetooth.cc
diff --git a/ash/system/bluetooth/tray_bluetooth.cc b/ash/system/bluetooth/tray_bluetooth.cc
index c635e10a4edf09d3d780a6e86f0a1a7b8f91ef32..27a3ae836e2f4796919780b7827d0f53bc13c8d1 100644
--- a/ash/system/bluetooth/tray_bluetooth.cc
+++ b/ash/system/bluetooth/tray_bluetooth.cc
@@ -338,7 +338,8 @@ class BluetoothDetailedView : public TrayDetailsView,
// Updates UI of the clicked bluetooth device to show it is being connected
// or disconnected if such an operation is going to be performed underway.
- void UpdateClickedDevice(std::string device_id, views::View* item_container) {
+ void UpdateClickedDevice(const std::string& device_id,
+ views::View* item_container) {
base::string16 display_name;
if (FoundDevice(device_id, paired_not_connected_devices_,
&display_name)) {
@@ -374,7 +375,7 @@ class BluetoothDetailedView : public TrayDetailsView,
find = device_map_.find(sender);
if (find == device_map_.end())
return;
- std::string device_id = find->second;
+ const std::string device_id = find->second;
if (FoundDevice(device_id, connecting_devices_, NULL))
return;
UpdateClickedDevice(device_id, sender);
« no previous file with comments | « no previous file | ash/test/test_session_state_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698