base/logging.h - Issue 1352613004: Cleanup: Pass std::string as const reference from ash/ + minor coding style changes in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 1352613004: Cleanup: Pass std::string as const reference from ash/ + minor coding style changes in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allocate |device_id| on the stack Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index f91d174b340246341def089373b7b8d0c52d5e39..e39251168cb46981d952146d7ac06c881c185b81 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -806,7 +806,7 @@ class BASE_EXPORT LogMessage {

// A non-macro interface to the log facility; (useful

// when the logging level is not a compile-time constant).

-inline void LogAtLevel(int const log_level, std::string const &msg) {

+inline void LogAtLevel(const int log_level, const std::string& msg) {

Daniel Erat 2015/09/23 19:20:39 (i don't know why the int parameter was const in t

ki.stfu 2015/09/23 19:48:00 +1

LogMessage(__FILE__, __LINE__, log_level).stream() << msg;

}

« no previous file with comments | « ash/test/test_session_state_delegate.cc ('k') | no next file » | no next file with comments »