third_party/WebKit/LayoutTests/fast/events/hr-timestamp/constructed-events.html - Issue 1352523002: Use high precision timestamp for Event.timestamp

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/hr-timestamp/constructed-events.html

Issue 1352523002: Use high precision timestamp for Event.timestamp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/test_runner/event_sender.cc ('k') | third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html » ('j') | third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5 <script type="text/javascript">

	6 'use strict';

	7 for (let eventType of [MouseEvent, KeyboardEvent, WheelEvent, GamepadEvent, Focu sEvent]) {

	8 test(function() {

	9 let now = performance.now();

	10 let e = new eventType('test');

	11 assert_approx_equals(e.timeStamp, now, 0.05, "Timestamp should be within 0.05 ms of the performance.now() when it was created");
	Rick Byers 2015/09/25 17:29:33 This might be too sensitive to avoid flakiness (eg This might be too sensitive to avoid flakiness (eg. imagine running on a very loaded machine, possibly with Valgrind/ASAN instrumentation, etc.). It also could fail when running under a debugger. Perhaps a better test that's immune to any amount of jank (or pausing in a debugger) would be to just verify that the timestamp is between (or equal) performance.now() from before the event was created and performance.now() from after it was created. WDYT? majidvp 2015/09/29 14:21:31 Makes sense. Done. Show quoted text On 2015/09/25 17:29:33, Rick Byers wrote: > This might be too sensitive to avoid flakiness (eg. imagine running on a very > loaded machine, possibly with Valgrind/ASAN instrumentation, etc.). It also > could fail when running under a debugger. > > Perhaps a better test that's immune to any amount of jank (or pausing in a > debugger) would be to just verify that the timestamp is between (or equal) > performance.now() from before the event was created and performance.now() from > after it was created. WDYT? Makes sense. Done.
	12 }, `Constructed ${eventType.prototype.constructor.name} timestamp should be high resolution and have the same time origin as performance.now()`);

	13 }

	14 </script>

OLD	NEW