Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: src/heap/gc-idle-time-handler.h

Issue 1352453004: Perform scavenge in idle tasks. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/heap/gc-idle-time-handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-idle-time-handler.h
diff --git a/src/heap/gc-idle-time-handler.h b/src/heap/gc-idle-time-handler.h
index ce4aeee9ee3218ffbd967425d271ffe7352a29dd..36acdd8531f1a177254c08ef6102d320db5d6cc5 100644
--- a/src/heap/gc-idle-time-handler.h
+++ b/src/heap/gc-idle-time-handler.h
@@ -14,7 +14,6 @@ enum GCIdleTimeActionType {
DONE,
DO_NOTHING,
DO_INCREMENTAL_STEP,
- DO_SCAVENGE,
DO_FULL_GC,
};
@@ -42,13 +41,6 @@ class GCIdleTimeAction {
return result;
}
- static GCIdleTimeAction Scavenge() {
- GCIdleTimeAction result;
- result.type = DO_SCAVENGE;
- result.additional_work = false;
- return result;
- }
-
static GCIdleTimeAction FullGC() {
GCIdleTimeAction result;
result.type = DO_FULL_GC;
@@ -77,10 +69,6 @@ class GCIdleTimeHeapState {
size_t mark_compact_speed_in_bytes_per_ms;
size_t incremental_marking_speed_in_bytes_per_ms;
size_t final_incremental_mark_compact_speed_in_bytes_per_ms;
- size_t scavenge_speed_in_bytes_per_ms;
- size_t used_new_space_size;
- size_t new_space_capacity;
- size_t new_space_allocation_throughput_in_bytes_per_ms;
};
@@ -124,21 +112,10 @@ class GCIdleTimeHandler {
static const int kMinBackgroundIdleTime = 900;
- // We conservatively assume that in the next kTimeUntilNextIdleEvent ms
- // no idle notification happens.
- static const size_t kTimeUntilNextIdleEvent = 100;
-
// An allocation throughput below kLowAllocationThroughput bytes/ms is
// considered low
static const size_t kLowAllocationThroughput = 1000;
- // If we haven't recorded any scavenger events yet, we use a conservative
- // lower bound for the scavenger speed.
- static const size_t kInitialConservativeScavengeSpeed = 100 * KB;
-
- // The minimum size of allocated new space objects to trigger a scavenge.
- static const size_t kMinimumNewSpaceSizeToPerformScavenge = MB / 2;
-
// If contexts are disposed at a higher rate a full gc is triggered.
static const double kHighContextDisposalRate;
@@ -181,11 +158,6 @@ class GCIdleTimeHandler {
static bool ShouldDoOverApproximateWeakClosure(size_t idle_time_in_ms);
- static bool ShouldDoScavenge(
- size_t idle_time_in_ms, size_t new_space_size, size_t used_new_space_size,
- size_t scavenger_speed_in_bytes_per_ms,
- size_t new_space_allocation_throughput_in_bytes_per_ms);
-
private:
GCIdleTimeAction NothingOrDone(double idle_time_in_ms);
« no previous file with comments | « BUILD.gn ('k') | src/heap/gc-idle-time-handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698