 Chromium Code Reviews
 Chromium Code Reviews Issue 1352453004:
  Perform scavenge in idle tasks.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1352453004:
  Perform scavenge in idle tasks.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/heap/heap.h | 
| diff --git a/src/heap/heap.h b/src/heap/heap.h | 
| index 3b6fd98da4f9cbe762c1754c2cdd0525e32065fe..e799963231c3c4b39b223b304d92abaeb44c1976 100644 | 
| --- a/src/heap/heap.h | 
| +++ b/src/heap/heap.h | 
| @@ -427,6 +427,7 @@ class HeapStats; | 
| class Isolate; | 
| class MemoryReducer; | 
| class ObjectStats; | 
| +class ScavengeJob; | 
| 
Hannes Payer (out of office)
2015/09/23 14:16:39
class Scavenger;
class ScavengeJob;
 
ulan
2015/09/23 15:05:16
Done.
 | 
| class Scavenger; | 
| class WeakObjectRetainer; | 
| @@ -1828,6 +1829,8 @@ class Heap { | 
| Address DoScavenge(ObjectVisitor* scavenge_visitor, Address new_space_front); | 
| + void ScheduleIdleScavengeIfNeeded(int bytes_allocated); | 
| 
Hannes Payer (out of office)
2015/09/23 14:16:39
Can you move it to the Idle notification section,
 
ulan
2015/09/23 15:05:16
Done.
 | 
| + | 
| void UpdateNewSpaceReferencesInExternalStringTable( | 
| ExternalStringTableUpdaterCallback updater_func); | 
| @@ -1882,6 +1885,10 @@ class Heap { | 
| void SetOldGenerationAllocationLimit(intptr_t old_gen_size, double gc_speed, | 
| double mutator_speed); | 
| + // Update the inline allocation limit. | 
| 
Hannes Payer (out of office)
2015/09/23 14:16:39
Make it a separate // Inline allocation. ===== sec
 
ulan
2015/09/23 15:05:16
Done.
 | 
| + void LowerInlineAllocationLimit(intptr_t step); | 
| + void ResetInlineAllocationLimit(); | 
| + | 
| // =========================================================================== | 
| // Idle notification. ======================================================== | 
| // =========================================================================== | 
| @@ -2266,6 +2273,8 @@ class Heap { | 
| ObjectStats* object_stats_; | 
| + ScavengeJob* scavenge_job_; | 
| + | 
| // These two counters are monotomically increasing and never reset. | 
| size_t full_codegen_bytes_generated_; | 
| size_t crankshaft_codegen_bytes_generated_; | 
| @@ -2339,6 +2348,7 @@ class Heap { | 
| friend class IncrementalMarking; | 
| friend class MarkCompactCollector; | 
| friend class MarkCompactMarkingVisitor; | 
| + friend class NewSpace; | 
| friend class ObjectStatsVisitor; | 
| friend class Page; | 
| friend class Scavenger; |