Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: src/heap/heap.h

Issue 1352453004: Perform scavenge in idle tasks. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 366afd0bc0f3d7251a7be4fcb8dd4686f4682ae4..89d61caef9f42067572912a556d2e8c3bd8a2eaf 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -15,6 +15,7 @@
#include "src/heap/gc-idle-time-handler.h"
#include "src/heap/incremental-marking.h"
#include "src/heap/mark-compact.h"
+#include "src/heap/scavenge-job.h"
Hannes Payer (out of office) 2015/09/21 09:00:57 Move this include to heap.cc
#include "src/heap/spaces.h"
#include "src/heap/store-buffer.h"
#include "src/list.h"
@@ -1187,6 +1188,10 @@ class Heap {
void EnableInlineAllocation();
void DisableInlineAllocation();
+ // Update the inline allocation limit.
+ void LowerInlineAllocationLimit(intptr_t step);
+ void ResetInlineAllocationLimit();
Hannes Payer (out of office) 2015/09/21 09:00:57 We should not expose them on the public heap API.
ulan 2015/09/23 09:58:38 Incremental marker calls these functions.
Hannes Payer (out of office) 2015/09/23 14:16:39 As discussed offline, we make them friends and do
+
// ===========================================================================
// Methods triggering GCs. ===================================================
// ===========================================================================
@@ -1211,6 +1216,9 @@ class Heap {
// Invoked when GC was requested via the stack guard.
void HandleGCRequest();
+ // Schedule idle scavenge job.
+ void ScheduleIdleScavenge(int bytes_allocated);
Hannes Payer (out of office) 2015/09/21 09:00:57 This one should be private as well.
ulan 2015/09/23 09:58:38 This is called by NewSpace on interrupt.
+
// ===========================================================================
// Iterators. ================================================================
// ===========================================================================
@@ -2265,6 +2273,8 @@ class Heap {
ObjectStats* object_stats_;
+ ScavengeJob scavenge_job_;
Hannes Payer (out of office) 2015/09/21 09:00:57 If you make ScavengeJob a ScavengeJob*, you don't
ulan 2015/09/23 09:58:38 Done.
+
// These two counters are monotomically increasing and never reset.
size_t full_codegen_bytes_generated_;
size_t crankshaft_codegen_bytes_generated_;
« no previous file with comments | « src/heap/gc-idle-time-handler.cc ('k') | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698