Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1352393002: Cleanup: Pass std::string as const reference from ui/ (Closed)

Created:
5 years, 3 months ago by ki.stfu
Modified:
5 years, 3 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Ian Vollick, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Pass std::string as const reference from ui/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=sadrul@chromium.org,sky@chromium.org Committed: https://crrev.com/e0013b8e130fee9807627e69277cd19a7f50e31b Cr-Commit-Position: refs/heads/master@{#350334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ui/accessibility/ax_node_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ki.stfu
5 years, 3 months ago (2015-09-20 20:17:22 UTC) #1
sadrul
lgtm
5 years, 3 months ago (2015-09-23 06:01:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352393002/1
5 years, 3 months ago (2015-09-23 06:03:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 18:15:03 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 18:35:25 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e0013b8e130fee9807627e69277cd19a7f50e31b
Cr-Commit-Position: refs/heads/master@{#350334}

Powered by Google App Engine
This is Rietveld 408576698