Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: snapshot/win/crashpad_snapshot_test_crashing_child.cc

Issue 1352323002: win: Make reading NT_IMAGE_HEADERS work cross-bitness (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@cleanup-crashpad-info
Patch Set: fixes2 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/snapshot_test.gyp ('k') | snapshot/win/crashpad_snapshot_test_image_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/crashpad_snapshot_test_crashing_child.cc
diff --git a/snapshot/win/crashpad_snapshot_test_crashing_child.cc b/snapshot/win/crashpad_snapshot_test_crashing_child.cc
index d74f6a62bddc3ac1e16aa0090a8adf4d95009fbd..7f4b8e5babaf68673ce96f3dd5111a47362009e2 100644
--- a/snapshot/win/crashpad_snapshot_test_crashing_child.cc
+++ b/snapshot/win/crashpad_snapshot_test_crashing_child.cc
@@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include <stdint.h>
-#include <stdlib.h>
#include <windows.h>
#include "base/logging.h"
@@ -33,7 +31,7 @@ int main(int argc, char* argv[]) {
CHECK(client.UseHandler());
HANDLE out = GetStdHandle(STD_OUTPUT_HANDLE);
- CHECK_NE(out, INVALID_HANDLE_VALUE);
+ PCHECK(out != INVALID_HANDLE_VALUE) << "GetStdHandle";
crashpad::WinVMAddress break_address = CurrentAddress();
crashpad::CheckedWriteFile(out, &break_address, sizeof(break_address));
« no previous file with comments | « snapshot/snapshot_test.gyp ('k') | snapshot/win/crashpad_snapshot_test_image_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698