Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1352313002: GN: Harmonize ARM compiler settings with GYP (Closed)

Created:
5 years, 3 months ago by Roland McGrath
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Harmonize ARM compiler settings with GYP This changes various defaults about the ARM compiler setup so that GN matches what GYP does today: * Prefix for cross tools is arm-linux-gnueabihf- not arm-linux-gnueabi- * arm_float_abi defaults to hard for non-Android ARMv7 * Non-CrOS ARM builds use the ARM sysroot by default (the one installed by install-build-deps.sh --arm) * Define a clang_arm toolchain, pass it the -no-integrated and -target arm-linux-gnueabihf and switches as GYP does R=dpranke@chromium.org, sbc@chromium.org BUG= Committed: https://crrev.com/cc3a331e1bc91166a5d51fc1fa44fba49d1fb461 Cr-Commit-Position: refs/heads/master@{#350100}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
M build/config/arm.gni View 1 chunk +5 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +2 lines, -0 lines 1 comment Download
M build/toolchain/linux/BUILD.gn View 1 chunk +25 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Roland McGrath
5 years, 3 months ago (2015-09-18 23:08:44 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/1352313002/diff/1/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/1352313002/diff/1/build/config/sysroot.gni#newcode48 build/config/sysroot.gni:48: sysroot = rebase_path("//mipsel-sysroot/sysroot") Looks like the mips path ...
5 years, 3 months ago (2015-09-19 08:40:06 UTC) #2
Roland McGrath
On 2015/09/19 08:40:06, Sam Clegg wrote: > lgtm > > https://codereview.chromium.org/1352313002/diff/1/build/config/sysroot.gni > File build/config/sysroot.gni (right): ...
5 years, 3 months ago (2015-09-19 22:27:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352313002/1
5 years, 3 months ago (2015-09-19 22:27:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/101900)
5 years, 3 months ago (2015-09-19 22:34:50 UTC) #7
Roland McGrath
dpranke: OWNERS review please
5 years, 3 months ago (2015-09-21 18:22:59 UTC) #8
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-22 01:16:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352313002/1
5 years, 3 months ago (2015-09-22 02:10:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 03:25:49 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 03:26:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc3a331e1bc91166a5d51fc1fa44fba49d1fb461
Cr-Commit-Position: refs/heads/master@{#350100}

Powered by Google App Engine
This is Rietveld 408576698