Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/image/SkImage_Gpu.cpp

Issue 1352293002: Revert[2] of add ImageShader, sharing code with its Bitmap cousin (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: undo change to test, check in Image_Gpu for nopt support Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/image/SkImage_Gpu.cpp
diff --git a/src/image/SkImage_Gpu.cpp b/src/image/SkImage_Gpu.cpp
index 163e62e02df540362952e9b55be47d3284d886a7..b9a283604947ccf7d1418ffd875faea69dd8d2d7 100644
--- a/src/image/SkImage_Gpu.cpp
+++ b/src/image/SkImage_Gpu.cpp
@@ -7,6 +7,7 @@
#include "SkBitmapCache.h"
#include "SkImage_Gpu.h"
+#include "GrCaps.h"
#include "GrContext.h"
#include "GrDrawContext.h"
#include "effects/GrYUVtoRGBEffect.h"
@@ -49,13 +50,6 @@ extern void SkTextureImageApplyBudgetedDecision(SkImage* image) {
}
}
-SkShader* SkImage_Gpu::onNewShader(SkShader::TileMode tileX, SkShader::TileMode tileY,
- const SkMatrix* localMatrix) const {
- SkBitmap bm;
- GrWrapTextureInBitmap(fTexture, this->width(), this->height(), this->isOpaque(), &bm);
- return SkShader::CreateBitmapShader(bm, tileX, tileY, localMatrix);
-}
-
bool SkImage_Gpu::getROPixels(SkBitmap* dst) const {
if (SkBitmapCache::Find(this->uniqueID(), dst)) {
SkASSERT(dst->getGenerationID() == this->uniqueID());
@@ -80,6 +74,19 @@ bool SkImage_Gpu::getROPixels(SkBitmap* dst) const {
}
GrTexture* SkImage_Gpu::asTextureRef(GrContext* ctx, SkImageUsageType usage) const {
+ const bool is_pow2 = SkIsPow2(this->width()) && SkIsPow2(this->height());
+ const bool npot_tex_supported = false; // ctx->caps()->npotTextureTileSupport()
+ if (!is_pow2 && kUntiled_SkImageUsageType != usage && !npot_tex_supported) {
+ // load as bitmap, since the GPU can support tiling a non-pow2 texture
+ // related to skbug.com/4365
+ SkBitmap bitmap;
+ if (this->getROPixels(&bitmap)) {
+ return GrRefCachedBitmapTexture(ctx, bitmap, usage);
+ } else {
+ return nullptr;
+ }
+ }
+
fTexture->ref();
return fTexture;
}

Powered by Google App Engine
This is Rietveld 408576698