Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1352283005: Add getConfiguration method to USBDevice. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add getConfiguration method to USBDevice. This allows a site to determine the current configuration state of a device. WebUSBDevice::getConfiguration is left as non-pure until Chromium provides an implementation. BUG=492204 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202621

Patch Set 1 #

Patch Set 2 : Update webexposed/global-interface-listing-expected.txt. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webusb/USBConfiguration.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webusb/USBConfiguration.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webusb/USBDevice.cpp View 2 chunks +31 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBDevice.idl View 1 chunk +1 line, -0 lines 0 comments Download
M public/blink_headers.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M public/platform/modules/webusb/WebUSBDevice.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 3 months ago (2015-09-21 23:30:35 UTC) #2
Ken Rockot(use gerrit already)
lgtm - i think you need to add getConfiguration to the expected interfaces list though
5 years, 3 months ago (2015-09-21 23:34:52 UTC) #3
Reilly Grant (use Gerrit)
dglazkov@, please take a look at public/blink_headers.gypi.
5 years, 3 months ago (2015-09-22 00:05:08 UTC) #5
dglazkov
lgtm
5 years, 3 months ago (2015-09-22 01:44:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352283005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352283005/20001
5 years, 3 months ago (2015-09-22 03:19:33 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 04:41:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202621

Powered by Google App Engine
This is Rietveld 408576698