Remove PlatformKeyboardEvents requirement to have located virtual keycode information.

Remove PlatformKeyboardEvents requirement to have located virtual keycode information.

Store the location of the key in the modifier mask. This brings the
location information in line with WebKeyboardEvent and avoids
a bunch of converstion to and from the located keycodes.

BUG=524626
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202591

[dtapuska, 2015-09-18 19:15:15]

dtapuska@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-09-21 15:13:44]

jochen@chromium.org changed reviewers:
+ rbyers@chromium.org

[jochen (gone - plz use gerrit), 2015-09-21 15:13:45]

+Rick because events

[Rick Byers, 2015-09-21 15:43:31]

rbyers@chromium.org changed reviewers:
- jochen@chromium.org

[Rick Byers, 2015-09-21 15:43:32]

Change looks good, but is there no test coverage for this at all that needs
updating?  I would have hoped there'd at least be some simple unit tests in
WebInputEventConversionTest or something.  But as it's mostly just dumb
plumbing, perhaps it's not worth it?  WDYT?

[dtapuska, 2015-09-21 15:56:54]

On 2015/09/21 15:43:32, Rick Byers wrote:
> Change looks good, but is there no test coverage for this at all that needs
> updating?  I would have hoped there'd at least be some simple unit tests in
> WebInputEventConversionTest or something.  But as it's mostly just dumb
> plumbing, perhaps it's not worth it?  WDYT?

This is really just plumbing that did a flip flop which wasn't necessary.

There are some tests to cover that the conversion between one format and
the other are correct for the location information. The fact that we flip
flop or don't do the flip flop is all internal to the two classes and
necessary to update a test case because it checks the inputs and outputs.

There are a also a series of LayoutTests that inject the appropriate
leftControl/rightControl and check that the key pressed is correct;
see fast/events/keydown-leftright-keys.html

[Rick Byers, 2015-09-21 16:01:38]

Ah thanks for the explanation - sounds perfect.  LGTM.

[dtapuska, 2015-09-21 16:47:55]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2015-09-21 16:48:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352283002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352283002/1

[commit-bot: I haz the power, 2015-09-21 18:18:45]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202591