telemetry: add smoothness.*.key_silk_cases benchmarks

telemetry: add smoothness.*.key_silk_cases benchmarks

Add two benchmark variants of smoothness with key_silk_cases.
smoothness.disable_gpu_rasterization.key_silk_cases:
  run with GPU rasterization explicitly diabled (but use impl-side painting)
smoothness.enable_gpu_rasterization.key_silk_cases:
  run with GPU rasterization enabled (implies impl-side painting).

R=nduca@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245440

[ernstm, 2014-01-10 23:52:47]

PTAL

[nduca, 2014-01-13 21:09:04]

https://codereview.chromium.org/135223002/diff/1/tools/perf/benchmarks/smooth...
File tools/perf/benchmarks/smoothness.py (right):

https://codereview.chromium.org/135223002/diff/1/tools/perf/benchmarks/smooth...
tools/perf/benchmarks/smoothness.py:35: test = smoothness.Smoothness
we have ./run_benchmark silk  now... should we rename that?

[ernstm, 2014-01-13 21:18:03]

https://codereview.chromium.org/135223002/diff/1/tools/perf/benchmarks/smooth...
File tools/perf/benchmarks/smoothness.py (right):

https://codereview.chromium.org/135223002/diff/1/tools/perf/benchmarks/smooth...
tools/perf/benchmarks/smoothness.py:35: test = smoothness.Smoothness
On 2014/01/13 21:09:04, nduca wrote:
> we have ./run_benchmark silk  now... should we rename that?

You mean renaming the silk benchmark?

[nduca, 2014-01-13 22:22:03]

yeah how about you remove the smoothnesskeysilkcases from this, we can chat
offline, and i can land what we agree on in my 003 patch

[nduca, 2014-01-13 22:22:11]

(lgtm assuming that)

[ernstm, 2014-01-14 18:35:22]

I had to add a disable-gpu-rasterization flag to create the benchmark
configurations we discussed yesterday. PTAL.

[nduca, 2014-01-14 18:37:07]

lgtm

[ernstm, 2014-01-14 20:46:47]

+kbr@ for OWNERS reviews of:
content/renderer/gpu/render_widget_compositor.cc

+thakis@ for OWNERS review of:
chrome/browser/chromeos/login/chrome_restart_request.cc
content/browser/renderer_host/render_process_host_impl.cc

[Nico, 2014-01-15 05:44:11]

On 2014/01/14 20:46:47, Manfred Ernst wrote:
> +kbr@ for OWNERS reviews of:
> content/renderer/gpu/render_widget_compositor.cc
> 
> +thakis@ for OWNERS review of:
> chrome/browser/chromeos/login/chrome_restart_request.cc
> content/browser/renderer_host/render_process_host_impl.cc

These two files lgtm

[Ken Russell (switch to Gerrit), 2014-01-16 22:19:29]

lgtm

[commit-bot: I haz the power, 2014-01-16 22:38:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/135223002/150001

[commit-bot: I haz the power, 2014-01-16 23:58:18]

Retried try job too often on win_rel for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-16 23:59:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/135223002/150001

[commit-bot: I haz the power, 2014-01-17 06:34:36]

Change committed as 245440

[danakj, 2014-02-14 23:30:43]

Is there a bug I can point to for this work/commandline flag?

[ernstm1, 2014-02-15 00:11:08]

No, there isn't a bug for this CL.

[danakj, 2014-02-15 00:12:50]

On 2014/02/15 00:11:08, ernstm1 wrote:
> No, there isn't a bug for this CL.

For GPU rasterization in general? I want to attach a bug to this command line
flag added here.

[ernstm1, 2014-02-15 01:10:10]

On 2014/02/15 00:12:50, danakj wrote:
> On 2014/02/15 00:11:08, ernstm1 wrote:
> > No, there isn't a bug for this CL.
> 
> For GPU rasterization in general? I want to attach a bug to this command line
> flag added here.

Sorry, I misunderstood. The tracking bug for GPU rasterization is:
crbug.com/316685

[danakj, 2014-02-15 01:13:50]

On Fri, Feb 14, 2014 at 8:10 PM, <ernstm@google.com> wrote:

> On 2014/02/15 00:12:50, danakj wrote:
>
>> On 2014/02/15 00:11:08, ernstm1 wrote:
>> > No, there isn't a bug for this CL.
>>
>
>  For GPU rasterization in general? I want to attach a bug to this command
>> line
>> flag added here.
>>
>
> Sorry, I misunderstood. The tracking bug for GPU rasterization is:
> crbug.com/316685


Thanks!

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.