Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1352173002: X87: Vector ICs: Hook up vectors in platform builtins to their SharedFunctionInfos. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Vector ICs: Hook up vectors in platform builtins to their SharedFunctionInfos. port 905e008c52ba06120f4a523aab00a53bc50830f1 (r30758) BUG= Committed: https://crrev.com/953024c6404ec1c3c62bd7d57367391cb7b4dda8 Cr-Commit-Position: refs/heads/master@{#30827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M src/x87/builtins-x87.cc View 7 chunks +24 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-18 07:16:11 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-18 11:21:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352173002/1
5 years, 3 months ago (2015-09-18 11:21:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 11:47:29 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 11:47:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/953024c6404ec1c3c62bd7d57367391cb7b4dda8
Cr-Commit-Position: refs/heads/master@{#30827}

Powered by Google App Engine
This is Rietveld 408576698