(Pre)Parser: Move FunctionState, BlockState and Scope handling to ParserBase.

(Pre)Parser: Move FunctionState, BlockState and Scope handling to ParserBase.

Notes:
- This removes Parser::FunctionState and PreParser::FunctionState and adds
ParserBase::FunctionState etc.
- Also the scope stacks and function state stacks are moved to ParserBase.
- PreParser::FunctionState didn't add and subtract
JSFunction::kLiteralsPrefixSize (unlike Parser::FunctionState). Since the
actual value of NextMaterializedLiteralIndex is not used in the Preparser,
this change is valid.
- Traits no longer need functions like is_classic_mode(), since now there is a
 unified way of getting the information from the FunctionState / Scope.

R=ulan@chromium.org
BUG=v8:3126
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=19361

[ulan, 2014-02-13 10:43:27]

lgtm

In addition to what we discussed offline:

https://codereview.chromium.org/135213007/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/135213007/diff/1/src/preparser.h#newcode116
src/preparser.h:116: typename Traits::FunctionStateParamType* extra_param =
NULL);
Maybe rename Traits::FunctionStateParamType to just Traits::Zone and extra_param
to zone. This will make at least one case (parser) readable. For preparser it
doesn't make sense, but it will be clear from the void typedef.

[marja, 2014-02-13 15:57:51]

Thanks for review! I did these changes, as discussed IRL:
- Moved Scope and Factory out of PreParserTraits (now they're PreParserScope and
PreParserFactory).
- Added a struct Type to the Traits classes and put the typedefs there.
- Clarified types by using the concrete types in all places.

https://codereview.chromium.org/135213007/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/135213007/diff/1/src/preparser.h#newcode116
src/preparser.h:116: typename Traits::FunctionStateParamType* extra_param =
NULL);
On 2014/02/13 10:43:27, ulan wrote:
> Maybe rename Traits::FunctionStateParamType to just Traits::Zone and
extra_param
> to zone. This will make at least one case (parser) readable. For preparser it
> doesn't make sense, but it will be clear from the void typedef.

Done.

[ulan, 2014-02-13 16:04:00]

nice, lgtm!

[marja, 2014-02-13 16:18:02]

Committed patchset #5 manually as r19361 (presubmit successful).