Add GetDeviceSupportedFormats to Android VideoCapture.java.

media/video/capture/android/video_capture_device_android.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/android/video_capture_device_android.h"
 
 #include <string>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 39 matching lines @@
              << ", unique_id="
              << name.id()
              << ", orientation "
              << Java_ChromiumCameraInfo_getOrientation(env, ci.obj());
   }
 }
 
 // static
 void VideoCaptureDevice::GetDeviceSupportedFormats(const Name& device,
     VideoCaptureFormats* formats) {
-  NOTIMPLEMENTED();
+  JNIEnv* env = AttachCurrentThread();

[bulach, 2014/02/13 14:08:23]

nit: could move this after the StringToInt..

[mcasas, 2014/02/14 11:28:39]

Done.

+  int id;
+  if (!base::StringToInt(device.id(), &id))
+    return;
+  base::android::ScopedJavaLocalRef<jobjectArray> collected_formats =
+      Java_VideoCapture_getDeviceSupportedFormats(env, id);
+  if (collected_formats.is_null())
+    return;
+
+  jsize num_formats = env->GetArrayLength(collected_formats.obj());
+  for (int i = 0; i < num_formats; ++i) {
+    base::android::ScopedJavaLocalRef<jobject> format(
+        env, env->GetObjectArrayElement(collected_formats.obj(), i));
+
+    VideoPixelFormat pixel_format = media::PIXEL_FORMAT_UNKNOWN;
+    switch (media::Java_CaptureFormat_getPixelFormat(env, format.obj())) {
+      case VideoCaptureDeviceAndroid::ANDROID_IMAGEFORMAT_YV12:
+        pixel_format = media::PIXEL_FORMAT_YV12;
+        break;
+      case VideoCaptureDeviceAndroid::ANDROID_IMAGEFORMAT_NV21:
+        pixel_format = media::PIXEL_FORMAT_NV21;
+        break;
+      default:
+        break;
+    }
+    formats->push_back(VideoCaptureFormat(
+        gfx::Size(media::Java_CaptureFormat_getWidth(env, format.obj()),
+                  media::Java_CaptureFormat_getHeight(env, format.obj())),
+        media::Java_CaptureFormat_getFramerate(env, format.obj()),
+        pixel_format));
+
+    VideoCaptureFormat& last_format = formats->back();

[bulach, 2014/02/13 14:08:23]

nit: maybe clang would complain since this will become unused on a non-debug
mode? wrapping with ifndef NDEBUG would be bad too, so here's a suggestion:

VideoCaptureFormat format(gfx::Size(...), getFrameRate, ...);
formats->push_back(format);
DVLOG(1) << ... ;

the compiler will hopefully optimize the local format away..

[mcasas, 2014/02/14 11:28:39]

Done.

+    DVLOG(1) << device.name() << " resolution: " <<
+        last_format.frame_size.ToString() << ", fps: " << last_format.frame_rate
+        << ", pixel format: " << last_format.pixel_format;
+  }
 }
 
 const std::string VideoCaptureDevice::Name::GetModel() const {
   // Android cameras are not typically USB devices, and this method is currently
   // only used for USB model identifiers, so this implementation just indicates
   // an unknown device model.
   return "";
 }
 
 // static
@@ skipping 179 matching lines @@
 void VideoCaptureDeviceAndroid::SetErrorState(const std::string& reason) {
   LOG(ERROR) << "VideoCaptureDeviceAndroid::SetErrorState: " << reason;
   {
     base::AutoLock lock(lock_);
     state_ = kError;
   }
   client_->OnError(reason);
 }
 
 }  // namespace media