Ensure GL initialization only happens once, and provide common init path

ui/compositor/test/default_context_factory.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/test/default_context_factory.h"
 
 #include "cc/output/output_surface.h"
 #include "ui/compositor/reflector.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_surface.h"
 #include "webkit/common/gpu/context_provider_in_process.h"
 #include "webkit/common/gpu/grcontext_for_webgraphicscontext3d.h"
 #include "webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h"
 
 namespace ui {
 
 DefaultContextFactory::DefaultContextFactory() {
+  DCHECK_NE(gfx::GetGLImplementation(), gfx::kGLImplementationNone);
 }
 
 DefaultContextFactory::~DefaultContextFactory() {
 }
 
-bool DefaultContextFactory::Initialize() {
-  if (!gfx::GLSurface::InitializeOneOff() ||

[piman, 2014/01/24 19:22:23]

So, there are a few non-unit-test executables that use this code - e.g.
aura_bench, aura_demo, views_examples_exe (found by looking for
InitializeContextFactoryForTests). Do you want to add
GLSurface::InitializeOneOff in those, or somehow still have
InitializeContextFactoryForTests do something?

[danakj, 2014/01/24 20:17:23]

I'll make them call GLSurface::InitializeOneOff() if they aren't already.

-      gfx::GetGLImplementation() == gfx::kGLImplementationNone) {
-    LOG(ERROR) << "Could not load the GL bindings";
-    return false;
-  }
-  return true;
-}
-
 scoped_ptr<cc::OutputSurface> DefaultContextFactory::CreateOutputSurface(
     Compositor* compositor, bool software_fallback) {
   DCHECK(!software_fallback);
   blink::WebGraphicsContext3D::Attributes attrs;
   attrs.depth = false;
   attrs.stencil = false;
   attrs.antialias = false;
   attrs.shareResources = true;
 
   using webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl;
@@ skipping 50 matching lines @@
 
   return shared_main_thread_contexts_;
 }
 
 void DefaultContextFactory::RemoveCompositor(Compositor* compositor) {
 }
 
 bool DefaultContextFactory::DoesCreateTestContexts() { return false; }
 
 }  // namespace ui