Issue 1352123002: Merge to M45: Resolve bad cast to CJS_EventHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1352123002: Merge to M45: Resolve bad cast to CJS_EventHandler (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@2454

Target Ref:
refs/heads/chromium/2454

Visibility:
Public.

More Reviews

Description

Merge to M45: Resolve bad cast to CJS_EventHandler At line 2026 in pdfsdk/src/javascript/PublicMethods.cpp, the writer wants to perform type cast like line 2027 but he made a mistake to make type conversion on m_pValue. Even at line 2027, it's redundant to make type conversion. The returned type of pContext->GetEventHandler() is CJS_EventHandler*. BUG=529310 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1325753007 . (cherry picked from commit 4ea0e6b972b0c6f6c9ad3f45a66a733d8dc3ca96) Committed: https://pdfium.googlesource.com/pdfium/+/880f927216c2f0666f69155da0ffc732747fafb8

Patch Set 1 #

Patch Set 2 : remove extra parens #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	fpdfsdk/src/javascript/PublicMethods.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

TBR. This one is small enough that I just manually applied it.

5 years, 3 months ago (2015-09-18 01:13:12 UTC) #1

Lei Zhang

5 years, 3 months ago (2015-09-18 01:13:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
880f927216c2f0666f69155da0ffc732747fafb8 (presubmit successful).

Expand Messages | Collapse Messages