Issue 13521008: Handle private fields from mixins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13521008: Handle private fields from mixins. (Closed)

Created:
7 years, 8 months ago by Johnni Winther

Modified:
7 years, 8 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle private fields from mixins. BUG=http://dartbug.com/9602 Committed: https://code.google.com/p/dart/source/detail?r=20966

Patch Set 2 : Update status. #

Patch Set 3 : Remove debug code. #

Total comments: 1

Patch Set 4 : Test added #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -25 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2	2 chunks	+17 lines, -16 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
A	tests/language/private_mixin2_test.dart	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
A +	tests/language/private_other_mixin2.lib	View	1 2 3	1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

https://codereview.chromium.org/13521008/diff/5001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (left): https://codereview.chromium.org/13521008/diff/5001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#oldcode1593 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1593: while (lookupClass.getLibrary() != memberLibrary) { Using [:lookupClass.getLibrary():] is invalidate ...

7 years, 8 months ago (2013-04-04 21:18:36 UTC) #2

kasperl

LGTM. It would be great if you could add a few more tests for mixed ...

7 years, 8 months ago (2013-04-05 05:33:33 UTC) #3