Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1976)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 13521002: Remove \r in command stdout/stderr when building failure a failure output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 773321746121a98932eee4574e604cfa08376491..46b83dc0744b8ba24bc461e95171067c0973beb3 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -98,13 +98,15 @@ List<String> _buildFailureOutput(TestCase test,
output.add('DRT pixel test failed! stdout is not printed because it '
'contains binary data!');
} else {
- output.add(decodeUtf8(test.lastCommandOutput.stdout));
+ output.addAll(decodeUtf8(test.lastCommandOutput.stdout)
+ .replaceAll('\r\n', '\n').split('\n'));
ahe 2013/04/03 10:13:58 How about creating a method for this? I suggest y
kustermann 2013/04/03 12:52:13 Done.
}
}
if (!test.lastCommandOutput.stderr.isEmpty) {
output.add('');
output.add('stderr:');
- output.add(decodeUtf8(test.lastCommandOutput.stderr));
+ output.addAll(decodeUtf8(test.lastCommandOutput.stderr)
+ .replaceAll('\r\n', '\n').split('\n'));
}
if (test is BrowserTestCase) {
// Additional command for rerunning the steps locally after the fact.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698