Issue 1352023002: Version 4.5.103.34 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1352023002: Version 4.5.103.34 (cherry-pick) (Closed)

Created:
5 years, 3 months ago by adamk

Modified:
5 years, 3 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@4.5

Target Ref:
refs/pending/branch-heads/4.5

Project:
v8

Visibility:
Public.

Version 4.5.103.34 (cherry-pick) Merged 21bd4564538b43dec9ff8c70d43c77a4696e4cfb Disallow Object.observe calls on access-checked objects BUG=chromium:531891 LOG=N TBR=jochen@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/134e541ad149b9732bc4fee6fe6952cf669703a7

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -2 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/messages.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/object-observe.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/runtime/runtime.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime/runtime-object.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	test/cctest/test-object-observe.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

adamk

5 years, 3 months ago (2015-09-17 21:20:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
134e541ad149b9732bc4fee6fe6952cf669703a7.