src/v8utils.h - Issue 13520004: [NOT FOR COMMIT] Native Client builds of V8 on ia32 and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8utils.h

Issue 13520004: [NOT FOR COMMIT] Native Client builds of V8 on ia32 and x64. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: A couple minor cleanups Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8utils.h

diff --git a/src/v8utils.h b/src/v8utils.h

index b5c8f084e02b95785e177846b70e8c4c9fe97612..0dbd60e21448d21712501007b7103aebb7b5d083 100644

--- a/src/v8utils.h

+++ b/src/v8utils.h

@@ -185,6 +185,13 @@ inline void MemsetPointer(T** dest, U* value, int counter) {

#elif defined(V8_HOST_ARCH_X64)

#define STOS "stosq"

#endif

+#if defined(__native_client__)

+ // This STOS sequence does not validate for x86_64 Native Client.

+ // Here we #undef STOS to force use of the slower C version.

+ // TODO(bradchen): Profile V8 and implement a faster REP STOS

+ // here if the profile indicates it matters.

+#undef STOS

+#endif

#if defined(__GNUC__) && defined(STOS)

asm volatile(