src/atomicops_internals_x86_gcc.h - Issue 13520004: [NOT FOR COMMIT] Native Client builds of V8 on ia32 and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/atomicops_internals_x86_gcc.h

Issue 13520004: [NOT FOR COMMIT] Native Client builds of V8 on ia32 and x64. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: A couple minor cleanups Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/atomicops_internals_x86_gcc.h

diff --git a/src/atomicops_internals_x86_gcc.h b/src/atomicops_internals_x86_gcc.h

index 6e55b50182c3231655d603a5c8178c77cfe488c3..9b2c5478d596bc9e8527a839b19ee42c72ee8953 100644

--- a/src/atomicops_internals_x86_gcc.h

+++ b/src/atomicops_internals_x86_gcc.h

@@ -168,7 +168,8 @@ inline Atomic32 Release_Load(volatile const Atomic32* ptr) {

return *ptr;

}

-#if defined(__x86_64__)

+#if defined(__x86_64__) && defined(V8_HOST_ARCH_64_BIT)

+// TODO(bradchen): Re-enable Atomic64 once rest is debugged.

// 64-bit low-level operations on 64-bit platform.