Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: src/heap/spaces.h

Issue 1351983002: [heap] refactor inline allocation step code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index 0bc1c175a2c019020ff17a1c1d724d3fb71decbf..1ed9ce8be96a5a934e50f9e05513a62a3ff3f450 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -2737,6 +2737,15 @@ class NewSpace : public Space {
bool EnsureAllocation(int size_in_bytes, AllocationAlignment alignment);
+ // If we are doing inline allocation in steps, this method performs the 'step'
+ // operation. Right now incremental mark is the only consumer of inline
+ // allocation steps. `top` the address just past the last byte allocated, i.e.
Hannes Payer (out of office) 2015/09/21 07:48:10 top is the memory address of the bump pointer at t
ofrobots 2015/09/21 20:32:58 Did you mean: "top is the memory address of the bu
+ // determines the numbers of bytes actually allocated since the last step.
+ // `new_top` is the address where that the next byte is going be allocated
Hannes Payer (out of office) 2015/09/21 07:48:10 address of the bump pointer
Hannes Payer (out of office) 2015/09/21 07:48:10 remove "that"
+ // from. `top` and `new_top` may be different when we cross a page boundary or
+ // reset the space.
+ void InlineAllocationStep(Address top, Address new_top);
+
friend class SemiSpaceIterator;
};
« no previous file with comments | « no previous file | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698