Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1351923002: Revert of Turn components/crash into a layered component. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
CC:
android-webview-reviews_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, droger+watchlist_chromium.org, dzhioev+watch_chromium.org, gunsch+watch_chromium.org, jochen+watch_chromium.org, kalyank, lcwu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, native-client-reviews_googlegroups.com, oshima+watch_chromium.org, sadrul, sdefresne+watchlist_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn components/crash into a layered component. (patchset #6 id:100001 of https://codereview.chromium.org/1315303004/ ) Reason for revert: This breaks Webkit layout tests. Original issue's description: > Turn components/crash into a layered component. > > The crash component cannot be used on iOS (as it depends on //content). > Turn it into a layered component so that it is possible to put shared > code related to crash there (components/crash_keys and objc_zombie.{h,mm}). > > BUG=522955 > TBR=sky@chromium.org > TBR=jschuh@chromium.org > NOPRESUBMIT=true > > Committed: https://crrev.com/4e483c64be5136b785e92c5baa971baca7eea2bc > Cr-Commit-Position: refs/heads/master@{#349384} TBR=blundell@chromium.org,jam@chromium.org,jschuh@chromium.org,mark@chromium.org,rsesek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522955 Committed: https://crrev.com/d7978868d7ebb7e8f671442f9515d947fab3e9ed Cr-Commit-Position: refs/heads/master@{#349417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6375 lines, -6386 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT_test.py View 1 chunk +1 line, -1 line 0 comments Download
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/crash_reporter/aw_microdump_crash_reporter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/client_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/kasko_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/breakpad.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/crash_upload_list_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/crash_service/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M chromecast/app/android/cast_crash_reporter_client_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/android/crash_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/app/cast_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/linux/cast_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/linux/cast_crash_reporter_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/cast_browser_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M components/components.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M components/crash.gypi View 1 chunk +306 lines, -310 lines 0 comments Download
D components/crash/README View 1 chunk +0 lines, -2 lines 0 comments Download
A components/crash/app/BUILD.gn View 1 chunk +79 lines, -0 lines 0 comments Download
A components/crash/app/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_linux.h View 1 chunk +32 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_linux.cc View 1 chunk +1760 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_linux_impl.h View 1 chunk +65 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_mac.h View 1 chunk +27 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_mac.mm View 1 chunk +286 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_mac_stubs.mm View 1 chunk +24 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_win.h View 1 chunk +28 lines, -0 lines 0 comments Download
A components/crash/app/breakpad_win.cc View 1 chunk +745 lines, -0 lines 0 comments Download
A components/crash/app/crash_keys_win.h View 1 chunk +82 lines, -0 lines 0 comments Download
A components/crash/app/crash_keys_win.cc View 1 chunk +192 lines, -0 lines 0 comments Download
A components/crash/app/crash_keys_win_unittest.cc View 1 chunk +142 lines, -0 lines 0 comments Download
A components/crash/app/crash_reporter_client.h View 1 chunk +158 lines, -0 lines 0 comments Download
A components/crash/app/crash_reporter_client.cc View 1 chunk +148 lines, -0 lines 0 comments Download
A components/crash/app/crashpad_mac.h View 1 chunk +54 lines, -0 lines 0 comments Download
A components/crash/app/crashpad_mac.mm View 1 chunk +251 lines, -0 lines 0 comments Download
A components/crash/app/hard_error_handler_win.h View 1 chunk +34 lines, -0 lines 0 comments Download
A components/crash/app/hard_error_handler_win.cc View 1 chunk +112 lines, -0 lines 0 comments Download
A components/crash/browser/BUILD.gn View 1 chunk +38 lines, -0 lines 0 comments Download
A components/crash/browser/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A components/crash/browser/crash_dump_manager_android.h View 1 chunk +85 lines, -0 lines 0 comments Download
A components/crash/browser/crash_dump_manager_android.cc View 1 chunk +174 lines, -0 lines 0 comments Download
A components/crash/browser/crash_handler_host_linux.h View 1 chunk +93 lines, -0 lines 0 comments Download
A components/crash/browser/crash_handler_host_linux.cc View 1 chunk +437 lines, -0 lines 0 comments Download
D components/crash/content/app/BUILD.gn View 1 chunk +0 lines, -79 lines 0 comments Download
D components/crash/content/app/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/crash/content/app/breakpad_linux.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/crash/content/app/breakpad_linux.cc View 1 chunk +0 lines, -1760 lines 0 comments Download
D components/crash/content/app/breakpad_linux_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/crash/content/app/breakpad_mac.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/crash/content/app/breakpad_mac.mm View 1 chunk +0 lines, -286 lines 0 comments Download
D components/crash/content/app/breakpad_mac_stubs.mm View 1 chunk +0 lines, -24 lines 0 comments Download
D components/crash/content/app/breakpad_win.h View 1 chunk +0 lines, -28 lines 0 comments Download
D components/crash/content/app/breakpad_win.cc View 1 chunk +0 lines, -745 lines 0 comments Download
D components/crash/content/app/crash_keys_win.h View 1 chunk +0 lines, -87 lines 0 comments Download
D components/crash/content/app/crash_keys_win.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D components/crash/content/app/crash_keys_win_unittest.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D components/crash/content/app/crash_reporter_client.h View 1 chunk +0 lines, -158 lines 0 comments Download
D components/crash/content/app/crash_reporter_client.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D components/crash/content/app/crashpad_mac.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/crash/content/app/crashpad_mac.mm View 1 chunk +0 lines, -251 lines 0 comments Download
D components/crash/content/app/hard_error_handler_win.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/crash/content/app/hard_error_handler_win.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D components/crash/content/browser/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D components/crash/content/browser/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/crash/content/browser/crash_dump_manager_android.h View 1 chunk +0 lines, -85 lines 0 comments Download
D components/crash/content/browser/crash_dump_manager_android.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D components/crash/content/browser/crash_handler_host_linux.h View 1 chunk +0 lines, -93 lines 0 comments Download
D components/crash/content/browser/crash_handler_host_linux.cc View 1 chunk +0 lines, -437 lines 0 comments Download
D components/crash/content/tools/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D components/crash/content/tools/crash_service.h View 1 chunk +0 lines, -125 lines 0 comments Download
D components/crash/content/tools/crash_service.cc View 1 chunk +0 lines, -487 lines 0 comments Download
D components/crash/content/tools/dmp2minidump.py View 1 chunk +0 lines, -51 lines 0 comments Download
D components/crash/content/tools/generate_breakpad_symbols.py View 1 chunk +0 lines, -262 lines 0 comments Download
A components/crash/tools/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A components/crash/tools/crash_service.h View 1 chunk +125 lines, -0 lines 0 comments Download
A components/crash/tools/crash_service.cc View 1 chunk +487 lines, -0 lines 0 comments Download
A components/crash/tools/dmp2minidump.py View 1 chunk +51 lines, -0 lines 0 comments Download
A components/crash/tools/generate_breakpad_symbols.py View 1 chunk +262 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/tools/content_shell_crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/breakpad_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/msan/blacklist.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sdefresne
Created Revert of Turn components/crash into a layered component.
5 years, 3 months ago (2015-09-17 14:24:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351923002/1
5 years, 3 months ago (2015-09-17 14:24:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 14:26:31 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 14:28:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7978868d7ebb7e8f671442f9515d947fab3e9ed
Cr-Commit-Position: refs/heads/master@{#349417}

Powered by Google App Engine
This is Rietveld 408576698