Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1351833002: Fix compilation error in mojo/shell/test_package_manager.h (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compilation error in http://crrev.com/1352663002 FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/shell/mojo_shell_unittests/test_package_manager.o.d ...omit... -c ../../mojo/shell/test_package_manager.cc -o obj/mojo/shell/mojo_shell_unittests/test_package_manager.o In file included from ../../mojo/shell/test_package_manager.cc:5: ../../mojo/shell/test_package_manager.h:23:32: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TestPackageManager(); ^ override 1 error generated. BUG=n/a TBR=yzshen@chromium.org,ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c5e4e66b7b63f247391730735a4fcd4bfca41ae4 Cr-Commit-Position: refs/heads/master@{#349358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/shell/test_package_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351833002/1
5 years, 3 months ago (2015-09-17 07:02:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 07:03:34 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 07:04:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5e4e66b7b63f247391730735a4fcd4bfca41ae4
Cr-Commit-Position: refs/heads/master@{#349358}

Powered by Google App Engine
This is Rietveld 408576698