|
Revert of Pinch/Zoom Infrastructure & Plumbing CL ( https://codereview.chromium.org/23983047/)
Reason for revert:
Broke Linux ASAN Tests (3) bot.
Original issue's description:
> Pinch/Zoom Infrastructure & Plumbing CL
>
> This CL supplies the necessary changes to CC to support the
> inner/outer viewport model for pinch-zoom and fixed-position
> elements. The specification for these changes is contained in
> the document "Layer-based Solution for Pinch Zoom / Fixed
> Position".
>
> It incorporates a change to how scrollbar parameters are
> computed (removes the notion of max_scroll_offset as a
> quantity set be the embedder, and instead inferred from the
> relative sizes of a clip layer w.r.t. the scroll layer).
>
> Scrollbars are generalized so that a layer may have more than
> two scrollbars, and the parameters of the scrollbar are set
> w.r.t. the sizes and positions of a clip and a scroll layer.
> Further, changes to the scrip/scroll layer automatically
> notify any attached scrollbars.
>
> The CL also removes existing references to root_scroll_layer
> from LTH, LTI and LTHI and replaces them with either
> Inner/OuterViewportScrollLayer (dual-layer operation only
> exists at present if the --enable-pinch-virtual-viewport flag
> is specified, otherwise behavior is unchanged).
>
> Logic is added to (i) combine scroll offsets for the two
> viewports before passing it to the embedder, and (ii)
> splitting any offsets received from the embedder
> appropriately between the two viewports.
>
> This CL relies on https://codereview.chromium.org/138453004/
> for changes in Blink to support it.
>
> BUG= 148816
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246812
>
> R=aelias@chromium.org, enne@chromium.org, joi@chromium.org, piman@chromium.org, sky@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247684
TBR=enne@chromium.org,aelias@chromium.org,joi@chromium.org,sky@chromium.org,piman@chromium.org,tony@chromium.org,wjmaclean@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 148816
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247688
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+992 lines, -1903 lines) |
Patch |
 |
M |
cc/animation/scrollbar_animation_controller_linear_fade.cc
|
View
|
|
1 chunk |
+8 lines, -10 lines |
0 comments
|
Download
|
 |
M |
cc/animation/scrollbar_animation_controller_linear_fade_unittest.cc
|
View
|
|
3 chunks |
+11 lines, -26 lines |
0 comments
|
Download
|
 |
M |
cc/animation/scrollbar_animation_controller_thinning.cc
|
View
|
|
1 chunk |
+22 lines, -16 lines |
0 comments
|
Download
|
 |
M |
cc/animation/scrollbar_animation_controller_thinning_unittest.cc
|
View
|
|
2 chunks |
+8 lines, -16 lines |
0 comments
|
Download
|
 |
M |
cc/layers/layer.h
|
View
|
|
2 chunks |
+6 lines, -8 lines |
0 comments
|
Download
|
 |
M |
cc/layers/layer.cc
|
View
|
|
5 chunks |
+16 lines, -49 lines |
0 comments
|
Download
|
 |
M |
cc/layers/layer_impl.h
|
View
|
|
7 chunks |
+19 lines, -17 lines |
0 comments
|
Download
|
 |
M |
cc/layers/layer_impl.cc
|
View
|
|
16 chunks |
+76 lines, -209 lines |
0 comments
|
Download
|
 |
M |
cc/layers/layer_impl_unittest.cc
|
View
|
|
14 chunks |
+40 lines, -40 lines |
0 comments
|
Download
|
 |
M |
cc/layers/layer_perftest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/layers/layer_position_constraint_unittest.cc
|
View
|
|
18 chunks |
+83 lines, -27 lines |
0 comments
|
Download
|
 |
M |
cc/layers/layer_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
cc/layers/painted_scrollbar_layer.h
|
View
|
|
4 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
 |
M |
cc/layers/painted_scrollbar_layer.cc
|
View
|
|
4 chunks |
+10 lines, -31 lines |
0 comments
|
Download
|
 |
M |
cc/layers/painted_scrollbar_layer_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/layers/scrollbar_layer_impl_base.h
|
View
|
|
5 chunks |
+5 lines, -19 lines |
0 comments
|
Download
|
 |
M |
cc/layers/scrollbar_layer_impl_base.cc
|
View
|
|
4 chunks |
+4 lines, -49 lines |
0 comments
|
Download
|
 |
M |
cc/layers/scrollbar_layer_interface.h
|
View
|
|
1 chunk |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
cc/layers/scrollbar_layer_unittest.cc
|
View
|
|
15 chunks |
+64 lines, -90 lines |
0 comments
|
Download
|
 |
M |
cc/layers/solid_color_scrollbar_layer.h
|
View
|
|
2 chunks |
+4 lines, -9 lines |
0 comments
|
Download
|
 |
M |
cc/layers/solid_color_scrollbar_layer.cc
|
View
|
|
2 chunks |
+10 lines, -39 lines |
0 comments
|
Download
|
 |
M |
cc/layers/solid_color_scrollbar_layer_impl.h
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
cc/layers/solid_color_scrollbar_layer_impl.cc
|
View
|
|
2 chunks |
+7 lines, -13 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_painted_scrollbar_layer.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_painted_scrollbar_layer.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
cc/test/layer_tree_json_parser.cc
|
View
|
|
1 chunk |
+1 line, -19 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host.h
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host.cc
|
View
|
|
3 chunks |
+17 lines, -70 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_common_unittest.cc
|
View
|
|
6 chunks |
+10 lines, -19 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl.cc
|
View
|
|
21 chunks |
+50 lines, -95 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl_unittest.cc
|
View
|
|
51 chunks |
+224 lines, -367 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_perftest.cc
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest.cc
|
View
|
|
4 chunks |
+4 lines, -12 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_animation.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_context.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_damage.cc
|
View
|
|
4 chunks |
+7 lines, -16 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_scroll.cc
|
View
|
|
18 chunks |
+118 lines, -222 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_impl.h
|
View
|
|
4 chunks |
+7 lines, -17 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_impl.cc
|
View
|
|
13 chunks |
+111 lines, -273 lines |
0 comments
|
Download
|
 |
M |
cc/trees/tree_synchronizer.cc
|
View
|
|
4 chunks |
+15 lines, -11 lines |
0 comments
|
Download
|
 |
M |
content/public/common/common_param_traits_macros.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/render_widget_compositor.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/test/web_layer_tree_view_impl_for_testing.h
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/test/web_layer_tree_view_impl_for_testing.cc
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
 |
M |
ui/gfx/transform.h
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
webkit/renderer/compositor_bindings/web_layer_impl.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
webkit/renderer/compositor_bindings/web_layer_impl.cc
|
View
|
|
2 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
 |
M |
webkit/renderer/compositor_bindings/web_scrollbar_layer_impl.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
webkit/renderer/compositor_bindings/web_scrollbar_layer_impl.cc
|
View
|
|
2 chunks |
+2 lines, -11 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|