Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351773002: Revert "Create a component for SSL error handling" (Closed)

Created:
5 years, 3 months ago by Justin Donnelly
Modified:
5 years, 3 months ago
Reviewers:
felt
CC:
chromium-reviews, blundell+watchlist_chromium.org, markusheintz_, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Create a component for SSL error handling" This reverts commit 7f1410648c7767ae8d466ada4385e78176f5db06. BUG=488673 TBR=felt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9f8cbaec845879ee09ff88b22ce8e264e4cb5ec3 Cr-Commit-Position: refs/heads/master@{#349283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -653 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +119 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/bad_clock_blocking_page.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ssl/ssl_error_classification.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ssl/ssl_error_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ssl/ssl_error_info.h View 4 chunks +18 lines, -22 lines 0 comments Download
A + chrome/browser/ssl/ssl_error_info.cc View 10 chunks +57 lines, -47 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/localized_error.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +0 lines, -1 line 0 comments Download
D components/ssl_errors.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/ssl_errors/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D components/ssl_errors/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/ssl_errors/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/ssl_errors/error_info.h View 1 chunk +0 lines, -79 lines 0 comments Download
D components/ssl_errors/error_info.cc View 1 chunk +0 lines, -255 lines 0 comments Download
D components/ssl_errors_strings.grdp View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Justin Donnelly
TBR
5 years, 3 months ago (2015-09-17 00:12:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351773002/1
5 years, 3 months ago (2015-09-17 00:13:49 UTC) #3
felt
lgtm thx for getting this fast
5 years, 3 months ago (2015-09-17 00:14:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 00:16:02 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 00:16:46 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9f8cbaec845879ee09ff88b22ce8e264e4cb5ec3
Cr-Commit-Position: refs/heads/master@{#349283}

Powered by Google App Engine
This is Rietveld 408576698