Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2171)

Unified Diff: content/child/child_io_surface_manager_mac.cc

Issue 1351753002: Mac: Ensure that Mach messages always get a reply (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/child_io_surface_manager_mac.cc
diff --git a/content/child/child_io_surface_manager_mac.cc b/content/child/child_io_surface_manager_mac.cc
index fb4ef9ac6524992b20166de6be75ca9ccf1f3b0c..16003e363602a75f09c5fa7dfb42e516667621d7 100644
--- a/content/child/child_io_surface_manager_mac.cc
+++ b/content/child/child_io_surface_manager_mac.cc
@@ -129,6 +129,15 @@ IOSurfaceRef ChildIOSurfaceManager::AcquireIOSurface(
return nullptr;
}
+ // Crash the renderer (for now) to see if this was the cause of renderer hangs
+ // that have recently been noticed.
+ // http://crbug.com/532149
+ CHECK(data.reply.msg.result);
+ if (!data.reply.msg.result) {
reveman 2015/09/18 18:22:30 nit: this if-statement seems unnecessary with the
ccameron 2015/09/18 18:36:00 Removed for now.
+ LOG(ERROR) << "AcquireIOSurface returned failure!";
+ return nullptr;
+ }
+
// Deallocate the right after creating an IOSurface reference.
base::mac::ScopedMachSendRight scoped_io_surface_right(
data.reply.msg.io_surface_port.name);

Powered by Google App Engine
This is Rietveld 408576698