Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1351693007: Add invalidation to url_response_disk_cache. (Closed)

Created:
5 years, 3 months ago by qsr
Modified:
5 years, 3 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add invalidation to url_response_disk_cache. Entry in the disk cache are invalidated when requested offline. They can be revalidated by caching a new version or explicitely revalidating the entry. This is necessary because if a downloaded application is buggy and crash the shell, it will never be updated and the user would be stuck in a crashing state. With this change, the crash will prevent the revalidation of the entry, and the next run will force an update of the application. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8dbcae1ef2202ffe7d8939d976ab1766112972d9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Messages

Total messages: 4 (0 generated)
qsr
5 years, 3 months ago (2015-09-22 12:59:18 UTC) #1
etiennej
lgtm https://codereview.chromium.org/1351693007/diff/1/shell/application_manager/network_fetcher.h File shell/application_manager/network_fetcher.h (right): https://codereview.chromium.org/1351693007/diff/1/shell/application_manager/network_fetcher.h#newcode52 shell/application_manager/network_fetcher.h:52: void LoadFromCache(); Some documentation on these methods would ...
5 years, 3 months ago (2015-09-22 14:53:29 UTC) #2
qsr
Committed patchset #2 (id:20001) manually as 8dbcae1ef2202ffe7d8939d976ab1766112972d9 (presubmit successful).
5 years, 3 months ago (2015-09-24 08:05:49 UTC) #3
qsr
5 years, 3 months ago (2015-09-24 08:08:24 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1351693007/diff/1/shell/application_manager/n...
File shell/application_manager/network_fetcher.h (right):

https://codereview.chromium.org/1351693007/diff/1/shell/application_manager/n...
shell/application_manager/network_fetcher.h:52: void LoadFromCache();
On 2015/09/22 14:53:29, etiennej wrote:
> Some documentation on these methods would be helpful in understanding what is
> doing what.

Done.

Powered by Google App Engine
This is Rietveld 408576698