Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 1351683004: GN: Simplify config by unconditionalising a flag that nacl-clang recognises (Closed)

Created:
5 years, 3 months ago by Mark Seaborn
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Sean Klein
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Simplify config by unconditionalising a flag that nacl-clang recognises Use of the flag "-Wno-inconsistent-missing-override" no longer needs to be conditionalised. This is also a step towards getting Skia to build with the (P)NaCl toolchains, because Skia currently needs to be compiled with this warning disabled. BUG=https://github.com/domokit/mojo/issues/431 TEST=build Committed: https://crrev.com/1ff21d98978803710edc806ca3eda3bb79c5107a Cr-Commit-Position: refs/heads/master@{#349511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
This is to upstream a Mojo-side change, https://codereview.chromium.org/1349933003/.
5 years, 3 months ago (2015-09-17 19:48:17 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-17 20:08:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351683004/1
5 years, 3 months ago (2015-09-17 20:44:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 22:10:52 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 22:11:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ff21d98978803710edc806ca3eda3bb79c5107a
Cr-Commit-Position: refs/heads/master@{#349511}

Powered by Google App Engine
This is Rietveld 408576698